feat(ion-datetime): add hidden-days when showDaysOutsideCurrentMonth prop is true #30209
+659
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add showDaysOutsideCurrentMonth property to datetime component; - change month generation to respect new property;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
JoaoFerreira-FrontEnd
changed the title
- create specific test page for showDaysOutsideCurrentMonth;
JoaoFerreira-FrontEnd
changed the title
BenOsodrac
requested changes
Feb 27, 2025
BenOsodrac
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Do we really need test for wheel type for this feature?
|
@JoaoFerreira-FrontEnd some screenshots are failing, please review this before requesting review 👍 Apart from the comments I already left, I didn't find anything more to comment on! It seems to be working as expected in runtime 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
Add a new property to datetime, showDaysOutsideCurrentMonth, that when true will show the last days of the previous month and the first days of the next month. This will just occupy empty "cells" at the beginning of the month "table" and add rows to the table until a maximum of 6 rows are displayed.
This property's default is false, so this should not introduce a breaking change.
Changes
Does this introduce a breaking change?
Other information